Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiComboBox: Sets focus back to the input element after each scroll #2589

Merged
merged 2 commits into from
Dec 3, 2019
Merged

EuiComboBox: Sets focus back to the input element after each scroll #2589

merged 2 commits into from
Dec 3, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Dec 3, 2019 •
edited
Loading

Summary

Closes #2583

In EuiComboBox sets focus back to the input element after each scroll. In order to do that I took advantage of the onScroll hook of the List component.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This was referenced Dec 3, 2019
Closed
Open
@ffknob ffknob changed the title Sets focus back to the input element after each scroll EuiComboBox: Sets focus back to the input element after each scroll Dec 3, 2019
@chandlerprall chandlerprall self-requested a review December 3, 2019 19:04
@chandlerprall
Copy link
Contributor

jenkins test this

chandlerprall
chandlerprall approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested locally to verify the base issue (#2583) is addressed and also checked the up/down arrow keys still work as expected to navigate the list.

@chandlerprall chandlerprall merged commit 489ca6a into elastic:master Dec 3, 2019
@thompsongl thompsongl mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiComboBox] When using the scrollbar no longer closes dropdown on outside click
3 participants
@ffknob @elasticmachine @chandlerprall